angular-restmod icon indicating copy to clipboard operation
angular-restmod copied to clipboard

Browser support

Open chris-hanson opened this issue 10 years ago • 2 comments

I'm hoping to use this library for an upcoming project, unfortunately I need to support IE8 :(

I can't find what browsers you support, so I did some quick testing on 8 and managed to get basic CRUD operations working with one minor change:

https://github.com/platanus/angular-restmod/blob/master/src/module/utils.js#L225

try { delete window.RestmodArray; }
catch (e) { window.RestmodArray = undefined; }

I'm happy to keep testing more advanced features, but if you are not looking to support 8 - there's not much point. Maybe you can add some info about supported browsers to the readme?

Let me know. Cheers.

chris-hanson avatar Sep 26 '14 03:09 chris-hanson

Hey Chris,

Currently restmod is being tested against the same browsers as angular, I initially wanted to have IE8 support but I haven't been able to test agains it using sauce labs. We currently use restmod here in Platanus in a project that requires IE7 support, Im using an older version of restmod in that project and didn't know it had broken for IE, but I will eventually need to fix it anyway.

I will gladdly add IE7-IE8 support officially if I manage to get the CI stuff to work with it.

I'll try again with sauce labs today, any PR related to IE8 bug fixes are very welcomed!

iobaixas avatar Sep 26 '14 13:09 iobaixas

Ha. I completely missed the bold paragraph about saucelabs. I'll continue testing other features and try to fix any issues I find.

chris-hanson avatar Sep 27 '14 02:09 chris-hanson