plasmic icon indicating copy to clipboard operation
plasmic copied to clipboard

Ignore sub-dependencies in findInstalledPackageJsonFile

Open zvictor opened this issue 2 years ago • 3 comments

Please check #47 for more details on the bug.

https://github.com/plasmicapp/plasmic/issues/47#issuecomment-1207393135 explains how this patch works. My solution is just a quick one to work around the problem for myself, but I do recommend that some extra effort is put into finding a better solution overall.

https://github.com/sindresorhus/resolve-cwd or https://github.com/sindresorhus/resolve-from might be more suitable than running such unnecessary and expensive glob. (I haven't tested and not sure they will work, but it's just something I would try)

zvictor avatar Aug 07 '22 11:08 zvictor

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
contenful-example ✅ Ready (Inspect) Visit Preview Aug 7, 2022 at 11:38AM (UTC)
plasmic ✅ Ready (Inspect) Visit Preview Aug 7, 2022 at 11:38AM (UTC)
plasmic-blog-example ✅ Ready (Inspect) Visit Preview Aug 7, 2022 at 11:38AM (UTC)
plasmic-blog-starter ✅ Ready (Inspect) Visit Preview Aug 7, 2022 at 11:38AM (UTC)
vercel-workflow ✅ Ready (Inspect) Visit Preview Aug 7, 2022 at 11:38AM (UTC)

vercel[bot] avatar Aug 07 '22 11:08 vercel[bot]

@zvictor is attempting to deploy a commit to the Plasmic Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 07 '22 11:08 vercel[bot]

@IcaroG anything else I can do for this PR?

zvictor avatar Aug 10 '22 14:08 zvictor

Sorry for the wait. Merged here https://github.com/plasmicapp/plasmic/commit/8fea13caca046cc9ed725694f7eda2e06bb54ded

IcaroG avatar Aug 15 '22 16:08 IcaroG