plasmic icon indicating copy to clipboard operation
plasmic copied to clipboard

[antd5] add Skeleton component

Open georg-malahov opened this issue 2 years ago • 4 comments

Add support for Skeleton component.

georg-malahov avatar Nov 28 '23 19:11 georg-malahov

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
react-email-demo ⬜️ Ignored (Inspect) Dec 19, 2023 5:05pm

vercel[bot] avatar Nov 28 '23 19:11 vercel[bot]

Hey @georg-malahov. Any reason for the change from defaultValueHint to defaultValue? Usually we prefer to use defaultValueHint if the value is already the default value of the prop.

IcaroG avatar Dec 19 '23 17:12 IcaroG

@IcaroG Yes, if am not mistaken now, by using defaultValueHint without providing exact defaultValue the conditional hidden property didn't work as expected. E.g. hidden: (ps) => ps.type !== "Avatar" && ps.avatar !== true, seemed to have no real values set in ps object.

georg-malahov avatar Dec 19 '23 17:12 georg-malahov