tljh-repo2docker icon indicating copy to clipboard operation
tljh-repo2docker copied to clipboard

Adopt `binderhub`

Open trungleduc opened this issue 10 months ago • 3 comments

User facing changes

This PR allows tljh-repo2docker to use binderhub service as the image build backend. By default, it still uses the local docker engine to build image via repo2docker, but if the binderhub_url is specified, it will switch to using binderhub service instead.

tljh

New configurations

  • binderhub_url: The optional URL of the binderhub service. If available, tljh-repo2docker will use this service to build images.
  • db_url: The database's connection string. tljh-repo2docker needs a database to store the image metadata. By default, it will create a sqlite database in the starting directory of the service. To use other databases (PostgreSQL or MySQL), users need to specify the connection string via this config and install the additional drivers (asyncpg or aiomysql).

New environment dialog when using binderhub service

environment-dialog

[!NOTE] The binderhub build backend does not support adding custom build arguments and private repository credentials from the interface.

Code changes

  • New database migration and management tools.
  • New handler to build images via binderhub service.
  • New handler to follow the build process.
  • Updated interfaces for building images.
  • New unit tests and UI tests for binderhub build backend.

trungleduc avatar Apr 05 '24 21:04 trungleduc

Nice, thanks @trungleduc for working on this!

Also cc @yuvipanda if you would like to help review and / or provide feedback. This should help with https://github.com/2i2c-org/binderhub-service/issues/78.

jtpio avatar Apr 17 '24 12:04 jtpio

This is super exciting to me. How can I help? Would it be via code review? Or something else?

yuvipanda avatar May 02 '24 22:05 yuvipanda

Hi @yuvipanda, a quick look at the implementation would be super helpful for us.

trungleduc avatar May 02 '24 22:05 trungleduc

Also @yuvipanda if you would like to start testing this on some deployments and have some feedback or issues, please don't hesitate to reach out!

jtpio avatar May 15 '24 10:05 jtpio