tljh-repo2docker icon indicating copy to clipboard operation
tljh-repo2docker copied to clipboard

nativeauthenticator's page.html is overshadowed

Open yamaton opened this issue 2 years ago • 3 comments

Hello, I'm running tljh-repo2docker with Native Authenticator. It runs fine, but some links at the top, "Change Password" and "Authorize Users", are gone.

I suppose this is because page.html in nativeauthenticator is overshadowed by the page.html in tljh-repo2docker.

Here is what you'd see if native authenticator is used alone:

yamaton avatar Jun 08 '22 01:06 yamaton

After reading Extending Templates, I figured the {{ super() }} directive is missing in tljh-repo2docker's page.html.

Shall I prepare a PR?

yamaton avatar Jun 09 '22 21:06 yamaton

Hello @yamaton thanks for your input.

My understanding of tljh-repo2docker is that authentication is handled externally. So, I'm worried that allowing the Native Authenticator could be problematic with other integrations.

Do you have any thought on this @jtpio?

pierrepo avatar Jun 10 '22 07:06 pierrepo

After reading Extending Templates, I figured the {{ super() }} directive is missing in tljh-repo2docker's page.html.

Ah that could be the case. Thanks @yamaton for catching this, feel free to open a PR to see if that can fix it..

jtpio avatar Jun 10 '22 10:06 jtpio