felicette icon indicating copy to clipboard operation
felicette copied to clipboard

Improve Dockerfile

Open SuperSandro2000 opened this issue 4 years ago • 9 comments

This saves just over 200MB uncompressed and follow some best practices.

docker images | grep felicette
felicette                                   latest              854f7da1165e        6 minutes ago       1.29GB
milhouse1337/felicette                      latest              be1fd7e006be        5 days ago          1.5GB

SuperSandro2000 avatar Jul 31 '20 13:07 SuperSandro2000

@milhouse1337 can review this better. Else I'll test and merge this over the weekend.

plant99 avatar Jul 31 '20 15:07 plant99

@SuperSandro2000 Thank you for this, it looks great! 👍

You can even remove the comments, it was not intended to be pushed. 😅

@plant99 I will rebuild the image on Docker Hub, based on this update.

milhouse1337 avatar Jul 31 '20 16:07 milhouse1337

@plant99 the Docker image has been updated. https://hub.docker.com/r/milhouse1337/felicette/tags

The size before: 572.88 MB (compressed) After: 454.23 MB (compressed)

milhouse1337 avatar Jul 31 '20 16:07 milhouse1337

@milhouse1337 comments got removed. I was not sure what to do with them.

I did some basic testing and one City generated a somewhat blurry image but the other was just black. This also happened with you old image so it is probably not the fault of my changes.

SuperSandro2000 avatar Aug 01 '20 07:08 SuperSandro2000

@SuperSandro2000 could you please test it with -l Amsterdam ?

I agree with the blurry and black image for some locations.

Thanks for the review @milhouse1337

plant99 avatar Aug 01 '20 08:08 plant99

Amsterdam does also not work.

SuperSandro2000 avatar Aug 01 '20 09:08 SuperSandro2000

Oh, weird. Let me look into it when I get back on a keyboard.

plant99 avatar Aug 01 '20 10:08 plant99

bump

SuperSandro2000 avatar May 25 '21 16:05 SuperSandro2000

bump

SuperSandro2000 avatar Apr 12 '22 11:04 SuperSandro2000