planka icon indicating copy to clipboard operation
planka copied to clipboard

Filter cards with shortcuts to users and labels

Open emmguyot opened this issue 10 months ago • 2 comments

Hi,

I've implemented the card search functionality #53. This feature allows users to search for :

  • cards based on their name
  • regular expression when starting with /
  • users with @xxx
  • labels with #xxx. It enhances the overall usability of the project and keep it simple with only a few click.

Changes made:

  • Added a search input field to the card list.
  • Updated the UI to display search results dynamically.

Testing:

  • Tested various search queries (including edge cases) to ensure accurate results.
  • Verified that the UI updates correctly when searching.

Preview : image

Thanks for reviewing! 🙌

emmguyot avatar Apr 14 '24 16:04 emmguyot

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 14 '24 16:04 CLAassistant

Hi! Thanks for working on this 🙏

We really like that it's possible to add members and labels right from the text, as well as search using regular expressions. We'd like to add slight style improvements for the search input.

Please note that we'll not be able to accept this PR without a signed CLA.

meltyshev avatar Apr 15 '24 15:04 meltyshev

Currently updating this PR to be able to filter by creator of the cards, using ! as the starting character

emmguyot-adscom avatar Apr 19 '24 10:04 emmguyot-adscom

amazing to see this onboarding, thank you!!

timmwille avatar Apr 19 '24 14:04 timmwille

The filter by creator is implemented. The description in this PR has been updated too

emmguyot avatar Apr 20 '24 18:04 emmguyot

Thank you! I'll try to check everything today/tomorrow :)

meltyshev avatar Apr 21 '24 12:04 meltyshev

I have a small suggestion to not add users/labels to the filter immediately. For example if a board has user @a and user @ab, when you type @a it's immediately added to the users filter, so there is no way to add user @ab this way.

Probably adding to the filter should be done only if there is a space after the username (or maybe you have any other suggestions)?

meltyshev avatar Apr 22 '24 14:04 meltyshev

I have a small suggestion to not add users/labels to the filter immediately. For example if a board has user @a and user @ab, when you type @a it's immediately added to the users filter, so there is no way to add user @ab this way.

Probably adding to the filter should be done only if there is a space after the username (or maybe you have any other suggestions)?

Well, in fact, in your case, when typing @a the a user won't be used to filter because it is used only if only one user fits your entry. So when typing @ab the ab user will be used. Though, the problem is, in this case, how to filter on a user. So using the space separator may be a way to solve this.

emmguyot-adscom avatar Apr 22 '24 17:04 emmguyot-adscom

So using the space separator may be a way to solve this.

I think that would be a good solution. Everything else works perfectly :)

meltyshev avatar Apr 22 '24 18:04 meltyshev

Both are fixed

emmguyot avatar Apr 22 '24 20:04 emmguyot

Perfect, thanks 🙏

meltyshev avatar Apr 22 '24 21:04 meltyshev

Hello This is a great feature, @emmguyot is it possible to extend the search to the description / comments (and not limited to the card title) ?

jpjoux avatar Apr 25 '24 08:04 jpjoux

Hello This is a great feature, @emmguyot is it possible to extend the search to the description / comments (and not limited to the card title) ?

Sure it's possible and quite simple. I don't think that the markdown syntax will be a problem that need a workaround. @meltyshev I go and create another PR ?

emmguyot avatar Apr 26 '24 18:04 emmguyot

You can check #729 PR

emmguyot avatar Apr 26 '24 19:04 emmguyot

Sure it's possible and quite simple. I don't think that the markdown syntax will be a problem that need a workaround. @meltyshev I go and create another PR ?

Thanks for the quick response with the fix! I'll accept the PR right away.

meltyshev avatar Apr 26 '24 19:04 meltyshev