soql
soql copied to clipboard
Relationships are not nullable
Hi there
Firstly, this is a great library so thanks for putting the effort in! So now onto the issue...
There are some optional relationships in my setup where the relationship does not always exist, i.e. the relationship is valid or it has a null value. The way this soql module works at the moment it is not possible to make Relationships nullable (for example by setting nullable=True).
I've patched this on my local installation so that I can set nullable=True
on relationships (basically allowing this to be set on the Relationship constructor and then passing the value along in the call to super).
I'm happy to submit a PR for this if that's intended functionality, although I haven't written a specific test for it yet :-)
Nullable relationships make sense to me. A PR would be welcomed 😁
PR submitted here: https://github.com/plangrid/soql/pull/12