react-file-viewer icon indicating copy to clipboard operation
react-file-viewer copied to clipboard

Suggestion: Add the ability to pass a loading indicator to the file viewer

Open HappyTreesDev opened this issue 5 years ago • 2 comments

As it sits, the loading indicator is not editable. It would be nice to be able to brand the loading indicator to match the rest of my application. This could be solved by adding the ability to pass a loading indicator component to the FileViewer component as a prop.

An example would be:

<FileViewer fileType="gif" filePath="pathToFile" loadingIndicator={MyLoadingIndicator} />

HappyTreesDev avatar Dec 30 '19 20:12 HappyTreesDev

I was going to take a crack at adding this feature in a pull request but I can't seem to test my code changes due to being on windows and it seems make is needed to run anything.

HappyTreesDev avatar Dec 30 '19 20:12 HappyTreesDev

This would be a really great feature. +1

d4mr avatar Mar 28 '20 18:03 d4mr