ghcommit-action icon indicating copy to clipboard operation
ghcommit-action copied to clipboard

Git crypt sometimes fails

Open gladykov opened this issue 1 year ago • 2 comments

We use git crypt and it works properly in Github actions. But with this action it (sometimes) fails:

"git-crypt" clean: line 0: git-crypt: not found
error: external filter '"git-crypt" clean' failed 127
error: external filter '"git-crypt" clean' failed
fatal: mmc/test/pats.ts: clean filter 'git-crypt' failed

Full log: log.txt

As it is not 100% reproducible, hard to tell why. But I suspect that adding git-crypt here https://github.com/planetscale/ghcommit-action/blob/main/Dockerfile could help.

Let me know if you would be open for PR.

gladykov avatar Oct 09 '24 16:10 gladykov

I'm not familiar with git-crypt. The base image we use pulls apk packages from the upstream wolfi-os distro. I don't see a git-crypt package available there, however - https://github.com/wolfi-dev/os. First step might be to submit a git-crypt package definition to wolfi.

joemiller avatar Oct 09 '24 17:10 joemiller

Thx! Will try there and see how it will go

gladykov avatar Oct 09 '24 17:10 gladykov

git-crypt is now available in Wolfi

tuananh avatar Oct 30 '24 21:10 tuananh

Thx! After rebuild will retest

gladykov avatar Oct 31 '24 11:10 gladykov

@gladykov I added git-crypt to the image in ghcommit-action v0.2.3. Please try it and if there is still an issue comment here and we can re-open this

joemiller avatar Jan 14 '25 18:01 joemiller