expressjs icon indicating copy to clipboard operation
expressjs copied to clipboard

Delete button on feedback page not working

Open dbuese opened this issue 8 years ago • 2 comments

Hi,

while viewing your course at Lynda.com, everything worked fine. Deleting feedback entries too. During the process of restarting npm via console a message appeared that a new version is available. I then executed: npm install -g npm it installed: npm -v 5.6.0

After upgrading npm, i noticed that deleting the feedback entries stopped working. As i am not aware of any other updates that mighthave occured on my system, i assume it is strongly related to the npm update.

I was able to fix this by changing app/public/js/feedback.js: < if (e.target.className == 'glyphicon glyphicon-remove') {

 if (e.target.className == 'feedback-delete btn btn-xs btn-danger') {

< output += '

';
output += '       <div class="media-left"><button id="' + key + '" class="feedback-delete btn btn-xs btn-danger"><span class="glyphicon glyphicon-remove"></span></button></div>';

I currently have Mac OS High Sierra with Firefox 57.0.3 installed.

Kind regards, Daniel

dbuese avatar Jan 03 '18 16:01 dbuese

replace

if (e.target.className == 'glyphicon glyphicon-remove') { with if (e.target.className == 'feedback-delete btn btn-xs btn-danger') {

and replace

output += '       <div class="media-left"><button class="feedback-delete btn btn-xs btn-danger"><span class="glyphicon glyphicon-remove"></span></button></div>'; 

with

output += '       <div class="media-left"><button id="' + key + '" class="feedback-delete btn btn-xs btn-danger"><span class="glyphicon glyphicon-remove"></span></button></div>';

dbuese avatar Jan 03 '18 16:01 dbuese

Please note that the delete feedback entry button works in Safari (Version 11.0.1 (11604.3.5.1.1)) without the mentioned changes.

dbuese avatar Jan 03 '18 20:01 dbuese