draino icon indicating copy to clipboard operation
draino copied to clipboard

helm: allow multiple values for node-label flag

Open morpheu opened this issue 4 years ago • 2 comments

This PR allow pass multiple values for node-label arg. Now when specify node-label on extraArgs it's a list instead string. Eg:

extraArgs:
  node-label:
    - "label1=value1"
    - "label2=value2"

morpheu avatar Feb 28 '20 14:02 morpheu

Codecov Report

Merging #65 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files           6        6           
  Lines         288      288           
=======================================
  Hits          246      246           
  Misses         40       40           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a877e7f...2b3d3d0. Read the comment docs.

codecov[bot] avatar Feb 28 '20 14:02 codecov[bot]

Thanks for this!

I believe existing chart users may be broken here if they used singular node-label: hello=world form. I think we may want to bump the chart version to 0.2.0 since this may affect folks using this chart with an existing values.yaml.

Side node - It might be worth updating the documentation in extraArgs as well (in fact, there's no docs there currently) to mention this behavior / provide hints that it's possible.

jacobstr avatar Feb 28 '20 23:02 jacobstr