draino icon indicating copy to clipboard operation
draino copied to clipboard

rbac modifications for permission issues

Open bilalcaliskan opened this issue 4 years ago • 2 comments

This PR fixes #92 and #51. There are couple of duplicated issues for that problem.

Draino fails when deployed with the manifest.yml in the repository. I have fixed the missing verbs in ClusterRole.

I have also fixed the golangci-lint error while linting the code.

bilalcaliskan avatar May 14 '21 18:05 bilalcaliskan

Codecov Report

Merging #117 (e26ca04) into master (9d39b53) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files           7        7           
  Lines         471      471           
=======================================
  Hits          356      356           
  Misses        101      101           
  Partials       14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d39b53...e26ca04. Read the comment docs.

codecov[bot] avatar May 14 '21 19:05 codecov[bot]

Hello @jacobstr , can you review the changes please :)

bilalcaliskan avatar May 14 '21 19:05 bilalcaliskan