RemainInMotion
RemainInMotion copied to clipboard
planetguy32
Buildcraft Wrench, Crescent Hammer, etc don't work
https://github.com/planetguy32/RemainInMotion/blob/master/src/main/java/me/planetguy/remaininmotion/core/ModInteraction.java#L166 is supposed to detect pretty much any wrench known to Steve-kind.
Indeed it is, but it doesn't. I will write an extensive log system for it so I can figure out why it isn't working.
I think I fixed it, I'm testing as soon as Minecraft stops crashing on startup from my attempts to not erase all previous carriages.
Suggestion: Rather than look for other mods' tool implementations and supporting those, it would be preferred if you could create an interface that other mod developers can use to pull in functionality of your screwdriver. In this way, you prevent breakages in other mods (in my case: Powersuits) and ensure that the mods which would like to support your mod can support it without potentially causing ill-defined behaviour. In this case, the bare powerfist, with no powerfist modules whatsoever installed, acts as an RiM screwdriver due to it implementing several tool interfaces and, though the normal functionality is limited based on which modules are installed with which MC mods, simply testing for these tool interfaces outside of the MC mod in question may in some cases cause this ill-defined behaviour.
I agree. We can make an interface, only the Project:Red screwdriver works as intended anyway as they all do strange things (like rotate).
If it's doing bad things we should remove the special wrench stuff, but IMO the last thing the world needs is another wrench API. I'd be inclined to stick to the Buildcraft and CoFH wrench APIs since they seem to be the most common.
Well, that would be one sane way of doing it, so long as RiM is inherently runtime dependent on whichever mod implements said tool API... On the other hand, if you're looking to eliminate runtime dependencies, you have to take into consideration if a mod inherits said tool interface specifically to support RiM and the mod which adds the aforementioned tool interface is not present (i.e. buildcraft), it would break functionality for the inheriting mod; therefore your own tool interface would be the way to go in this case. The choice is up to you, really just needed to report (as current maintainer of Powersuits) this is definitely not only related to, but causing the Powersuits' bug reported here: https://bugzilla.qmxtech.com/show_bug.cgi?id=19
or, you could simply include a copy of the API you use (eg: Buildcraft Tool API) in your build and use it as a plan B if there's no newer version found.
