RemainInMotion icon indicating copy to clipboard operation
RemainInMotion copied to clipboard

Fluid loss on moving BC tanks

Open da3dsoul opened this issue 9 years ago • 7 comments

Not sure why, or if it's tanks or pipes yet. I just built a loop that empties from a tank and fills it back up, then moved it back and forth.

da3dsoul avatar Apr 20 '15 23:04 da3dsoul

Does this still happen if you build the same setup rotated 90 degrees? What if you move the engine elsewhere adjacent to it?

I'm guessing this could be caused by saving a pipe that has received fluid but hasn't saved the change.

planetguy32 avatar Apr 21 '15 03:04 planetguy32

I can't find any good details on it, but it looks like Buildcraft uses multithreading for some things. That could make this a concurrency bug, which would make it very difficult to deal with.

I'll try a bit more to replicate it. (Edit: I've successfully replicated the problem.)

planetguy32 avatar Apr 22 '15 22:04 planetguy32

I put some water in a tank and moved it, and the tank was empty when placed down. It's definitely the tanks.

I'd guess it's something a bit like the problem with Carpenters' Blocks, resetting the TileEntity.

planetguy32 avatar Apr 22 '15 23:04 planetguy32

Looking over the Tank code, I see no reason why it wouldn't work. I have been playing with the fluid system to make ABO reinforced pipes better (I did, thanks), and there is no multithreading anywhere in there. I'm going to build a different type of test rig to see if it's a different kind of issue.

da3dsoul avatar May 07 '15 06:05 da3dsoul

Ok, I can confirm it is not an update or rendering glitch. The fluid is destroyed.

da3dsoul avatar May 07 '15 06:05 da3dsoul

I haven't tried this recently. I'll try and see if it still happens.

da3dsoul avatar Oct 02 '15 19:10 da3dsoul

not to sound derpy or anything, but I've noticed most Tanks and Containers like to save Fluid info in the .withTag() Meta, and I didn't see anyone mention it yet, but, have y'all ensured that you are checking for, grabbing, saving, and re-applying, said Meta to the Tank Blocks that you're moving?

Blue64 avatar Apr 10 '17 21:04 Blue64