nos icon indicating copy to clipboard operation
nos copied to clipboard

[NIP05 FE] Users without a NIP05 see the ½ sheet pop-up 5 seconds after opening the app

Open setch-l opened this issue 1 year ago • 8 comments

Given that I am a user of nos.social who does not have a valid NIP05 and this is not my first time using the app When I re-open the app Within 5 seconds I should see the ½ sheet slide up offering me the option to create my own NIP 05 or register an existing NIP05 with the following elements on the sheet:

New Claim your unique identity on Nostr

Welcome to Nos, where your voice matters. Secure your unique @username.nos.social

[button] Set up my @username

Designs:

https://www.figma.com/file/s0qf4VmyQygydP8MIQazZc/Nos?type=design&node-id=4978%3A3185&mode=design&t=t7hnc5cdHeWpiQ9J-1

setch-l avatar Jan 16 '24 14:01 setch-l

@setch-l Are we sure about this one? Anything that happens on a timer could be incredibly disrupting to the user. What if they're composing a note, or trying to tap the like or repost button, or typing a search term? It seems like we have other options, like putting this into a large banner or some other prominent UI across every screen in the app.

joshuatbrown avatar Feb 29 '24 22:02 joshuatbrown

@joshuatbrown - I think that is a fair point. I was thinking upon second open and then never showing it again. So you install the app - do whatever you want to do, then when you reopen a second time - the pop-up appears. But then you never see it again unless you visit the edit profile screen where it's embedded in the screen.

If you think we should have it as a banner - let's just have it live at the top of the Notifications tab. Once the user creates a NIP05 it goes away.

setch-l avatar Feb 29 '24 22:02 setch-l

@setch-l I'm OK with showing it the second time you open the app, I think. I'm mainly concerned about the 5-second delay that could disrupt the user. In the case of showing it as soon as they launch it for the second time, it could be a little bit in their way (worst case) but won't interrupt something they're doing.

I'm also fine with it being a banner at the top of Notifications. Don't know what's best.

joshuatbrown avatar Mar 01 '24 19:03 joshuatbrown

ah - I see - then we can remove the 5 sec delay upon second open of the app.

On Fri, Mar 1, 2024 at 2:27 PM Josh Brown @.***> wrote:

@setch-l https://github.com/setch-l I'm OK with showing it the second time you open the app, I think. I'm mainly concerned about the 5-second delay that could disrupt the user. In the case of showing it as soon as they launch it for the second time, it could be a little bit in their way (worst case) but won't interrupt something they're doing.

— Reply to this email directly, view it on GitHub https://github.com/planetary-social/nos/issues/803#issuecomment-1973789958, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTTX5UGSIQ7IAWK2C4RKRDYWDJDLAVCNFSM6AAAAABB44RMNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZTG44DSOJVHA . You are receiving this because you were mentioned.Message ID: @.***>

setch-l avatar Mar 01 '24 19:03 setch-l

@martindsq - I cannot make this appear after trying with two accounts. I've also looked in the Notifications tab and I'm not seeing it there either.

setch-l avatar Mar 21 '24 17:03 setch-l

@setch-l are you killing the app and opening it again, or just sending it to the background? I just tested with a new account, killed the app, and after opening it again, it showed the dialog.

martindsq avatar Apr 22 '24 19:04 martindsq

I actually have the opposite problem where it sometimes appear after I login even though I have a NIP-05.

joshuatbrown avatar Apr 23 '24 15:04 joshuatbrown

@martindsq - Let me retest this - drop it into UAT. @joshuatbrown - LMK if you can reproduce the issue consistently.

setch-l avatar Apr 23 '24 17:04 setch-l