planetary-social
Fixes alerts when uploading big files and suggests users subscribe to nostr.build
This is a fix for ticket #1275
Provides a better error message and gives the option to pay for nostr.build
@rabble unfortunately that error message is usually a lie and is hiding the real error. Try commenting out some of your changes until you narrow down the line that is wrong. If that doesn't help maybe @joshuatbrown or I can take a look on Monday.
Also we've picked up the habit as marking WIP PRs as "drafts" in Github. We'll still review them, but it's just an extra signal that it's not ready for merging yet. You can click the "convert to draft" button up by the reviewers to make this PR a draft.
There is also a bug I see that XCStringsTool isn't generating accessors for Nos/Assets/Localization/ImagePicker.xcstrings. I don't see a way to fix that in the docs. There isn't a configuration file that I see. @joshuatbrown do you know how to fix this off the top of your head? I know you tried removing XCStringsTool recently.
There is also a bug I see that XCStringsTool isn't generating accessors for
Nos/Assets/Localization/ImagePicker.xcstrings. I don't see a way to fix that in the docs. There isn't a configuration file that I see. @joshuatbrown do you know how to fix this off the top of your head? I know you tried removing XCStringsTool recently.
Ah, i wasn't aware xcode had a way of editing those files visually... i was editing the json.. i've now tried opening the file from teh CLI and it shows an editor.... i added spanish too. Should be fixed..
I think it's ready for you guys to look at again.
This works perfectly and I'm glad we're looking for the HTTP 413! I just have some comments on how it's implemented, and I'd love to see a unit test or two. I have some ideas for how to do that, so I'm happy to help if needed.
@joshuatbrown, this is something I have been looking forward to do. I would be happy to have a guide on the unit testing.
