nos icon indicating copy to clipboard operation
nos copied to clipboard

[3 Dots Note menu] Update the copy on 3 dots note menu

Open setch-l opened this issue 1 year ago • 1 comments

Given that I am a user of nos When I want to share a note Then I should have clear language of what to use inside of Nos and outside of nos.

AC Update the menu options to read: Copy Nostr note ID [share icon] Share note Copy note text View source Flag this note Cancel

setch-l avatar Apr 10 '24 17:04 setch-l

Isn't this the same as #1010 ?

dcadenas avatar Apr 24 '24 19:04 dcadenas

@dcadenas this isn't the same; the copy here is different than what's in that ticket.

joshuatbrown avatar Aug 29 '24 15:08 joshuatbrown

@setch-l, just to be super clear, can any user share any note on the app?

pelumy avatar Sep 06 '24 16:09 pelumy

@pelumy - Yes. We do not support DMs at the moment so any note can be shared externally.

setch-l avatar Sep 06 '24 17:09 setch-l

@setch-l , I see in the ticket description that the share button should have an icon, but with the current implementation, iOS default confirmation dialog does not allow images in the buttons, but only texts.

To include a share icon, we would need a custom confirmation sheet, which would mean changing the way the code is written for this confirmation sheet. Do we want to invest time in doing this, or it is fine to just use the "Share note" text on the button without the icon?

pelumy avatar Sep 06 '24 19:09 pelumy

@pelumy - Please do not include the icon on the button.

setch-l avatar Sep 09 '24 13:09 setch-l