libplanet icon indicating copy to clipboard operation
libplanet copied to clipboard

Make the KeyStore configurable in CoconaCommands

Open ipdae opened this issue 3 years ago • 1 comments
trafficstars

I found this issue while progressing on https://github.com/planetarium/NineChronicles.Headless/pull/1272. In NinceChronicles.Headless uses the Libplanet.Extensions.Cocona.commands wrapped once & use it because without need a dependency from the user's point of view. However, there is an inconvenience of copying and using the same code in headless. because, Libplanet commands always set the KeyStore to Web3.DefaultStore but headless commands can configure KeyStore. If the Libplanet commands changes the KeyStore to be configurable, it seems to be possible to use it immediately without copying unnecessary code.

ipdae avatar May 20 '22 01:05 ipdae

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 01:07 stale[bot]