NineChronicles icon indicating copy to clipboard operation
NineChronicles copied to clipboard

Develop event dungeons

Open boscohyun opened this issue 3 years ago • 4 comments

  • Bump lib9c: https://github.com/planetarium/lib9c/pull/1218
  • Apply new sheets to AddressableAssetsContainer and TableSheets
  • Introduce RxProps.Event
  • Refactor data loading logic when avatar selection.
  • Introduce event_dungeon_name.csv file for localization.
  • Implement all UI flow for event dungeon.
  • Implement all UI flow for event recipe.

boscohyun avatar Jul 21 '22 13:07 boscohyun

@boscohyun The versions of bundled Libplanet assemblies and Libplanet submodule vendored by Lib9c apparently do not match:

  • Libplanet submdoule: 0.37.0
  • Libplanet.Net.dll: 0.39.0
  • Libplanet.RocksDBStore.dll: 0.39.0
  • Libplanet.Stun.dll: 0.39.0
  • Libplanet.dll: 0.39.0

Leave a comment in this pull_request with the following command to let the bot upgrade bundled Libplanet assemblies:

/update-libplanet-dlls

github-actions[bot] avatar Jul 26 '22 12:07 github-actions[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 05 '22 10:08 CLAassistant

@boscohyun Your pull request does not pass lint checks. You probably haven't configured hooks in your local Git repository. Please configure Git hooks in your local repository using the below command:

git config core.hooksPath hooks

github-actions[bot] avatar Aug 12 '22 02:08 github-actions[bot]

This PR has 13581 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +11415 -2166
Percentile : 100%

Total files changed: 169

Change summary by file extension:
.prefab : +4289 -552
.anim : +902 -429
.meta : +3417 -308
.controller : +72 -0
.asset : +12 -0
.mat : +11 -8
.spriteatlas : +70 -0
.csv : +51 -15
.cs : +2469 -853
.json : +120 -0
.DotSettings : +1 -0
nekoyume/Assets/_Scripts/Lib9c/lib9c : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.


Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.