QuickNFO icon indicating copy to clipboard operation
QuickNFO copied to clipboard

thumbnails broken - project dead?

Open tessus opened this issue 6 years ago • 6 comments

Hi Felix,

I've compiled master and reverted the colors again - sorry classic NFOs are white on black.

But the thumbnail icons are not working properly. This is what I get in the examples directory:

image

It seems that you provide an AppStore version, so does this mean that this open source project is dead? I mean a lot of people have the source on github and still sell a compiled version in the AppStore. However, it looks like the version in the AppStore has some issues according to the comments.

I'm not saying that you should make the entire app available, but at least you could update the quicklook part here on github.

In any case, maybe you can update the status in the README, so that people know what's going on.

tessus avatar Jan 15 '19 21:01 tessus

The icons don't seem to work properly currently... Maybe someone else has the time to look into this - I haven't, sorry.

I think you can see from the commit dates that this project has not been updated for a long time. In fact, the App Store version is even older and I'm suprised that it still works.

planbnet avatar Jan 18 '19 10:01 planbnet

@planbnet thanks for the info. I hoped that the AppStore version had working preview icons and that you could just update the code here. Too bad that this is not the case. I'm not quite sure, why the code is not working. The scaling algorithm looks fine, but maybe I'm missing something.

Well, I don't have any NFO files these days anyway, but thought of it as a matter of principle.

tessus avatar Jan 18 '19 17:01 tessus

@herrbischoff has a fork of this project that works for me. I ended up building it myself, as Catalina didn't want to run it without it being signed. Actually finding the built qlgenerator file was fun - exporting from the Archive window apparently does that?

Anyway, if it helps, this fork is what I used.

broberson avatar Sep 24 '20 17:09 broberson

@broberson this makes no sense. The repo you linked has no code changes compared to this one.

tessus avatar Sep 24 '20 18:09 tessus

That fork said it was created to provide a more current binary, which turned out to also be unsigned and didn't work for me on Catalina, so I used the code in it to compile my own. It worked.

If there are no code changes, doing the same with this repo would have worked as well, but that's not what I did, so that's not what I recommended. I just wanted to be able to read some NFO files and figured I'd help out anyone having the same problem I was having by leaving a comment here.

If you have an Apple Developer account, maybe you can fork this repo, build a new, signed binary, and issue a pull request? I don't, so I can't.

broberson avatar Sep 24 '20 21:09 broberson

I don't have a dev account and I won't get one, because Apple requires 2FA which uses either a phone number to send text messages or requires the use of iCloud. Neither is acceptable to me.

Also, this issue was about the broken thumbnails, not a missing or more recent binary, thus I didn't understand your message. Without code changes the icons will still be broken.

tessus avatar Sep 24 '20 22:09 tessus