tpp-mlir icon indicating copy to clipboard operation
tpp-mlir copied to clipboard

Investigate re-enabling `mlir-doc` target

Open rolfmorel opened this issue 1 year ago • 3 comments

#939 removed the lines of the README regarding being able to build TableGen-derived documentation. The issue is that the mlir-doc target is broken at the moment.

We should investigate the issue (a CMakelists.txt issue?), fix it, and add building this target to the CI. When that's done, we can add back the README lines on generating the documentation.

rolfmorel avatar Jun 24 '24 13:06 rolfmorel

This probably needs CheckOps.td to be split into a separate dialect TD file. Good opportunity to also do some minor cleanup.

adam-smnk avatar Jun 24 '24 13:06 adam-smnk

@rengolin Should we add docs to CI? Otherwise, IMO no point in maintaining it at all as we don't really use them.

adam-smnk avatar Jun 24 '24 13:06 adam-smnk

The question here is if we want to maintain this at all. If the answer is yes, then we must do it right and add it to CI. Otherwise we just close this issue and don't think about it.

rengolin avatar Jun 24 '24 15:06 rengolin