react-native-plaid-link-sdk icon indicating copy to clipboard operation
react-native-plaid-link-sdk copied to clipboard

LinkEventMetadata attribute casing not consistent between iOS and Android

Open jennifer-dickinson opened this issue 4 years ago • 3 comments
trafficstars

The problem

In trying to handle item-no-error, we found that Android would never receive an errorCode from the a link event. Root cause seems to be that LinkEventMetadata attribute names are snake case for android.

Environment

Plaid Link React Native 7.0.5
ReactNative Version 0.64.2
Occurs on Android yes
Android OS Version 11
Android Devices/Emulators Pixel 4
Occurs on iOS no
iOS Version n/a
iOS Devices/Emulators n/a

Steps to Reproduce

Observe events from usePlaidEmitter; View attribute names LinkEventMetadata in Android and compare to iOS.

Expected Result

Expect meta data to match LinkEventMetadata interface

Screenshots

Top two lines are Android, bottom two lines are iOS. Screen Shot 2021-10-21 at 11 22 35 AM

jennifer-dickinson avatar Oct 21 '21 19:10 jennifer-dickinson

Hi Jennifer, thank you for flagging this. We have had other reports also asking about this SDK's inconsistency with react-plaid-link's types (which are snake_cased), and the teams are looking to unify across multiple axes. Apologies in the meantime.

amytang0 avatar Oct 22 '21 17:10 amytang0

Update on this - it is still an issue. We are seeing only camelCase event properties on one platform and only snake_case on the other. This is hard to manage in Amplitude and messes with our funnel tracking.

We are now on Plaid SDK 7.1.0 and pod 2.2.1. Still on React Native 0.64.2.

The type definition of LinkEventMetadata in your SDK does not match the reality of the snake_case fields being returned! We can write our own transform code but we're still holding out for a fix.

  1. Any update on when this will be fixed?
  2. Which format will eventually be the standard - camelCase, snake_case, or something else?

a613 avatar Jan 31 '22 22:01 a613

We noticed this too.

I'd love to know when this might be fixed!

nchase avatar Feb 17 '22 19:02 nchase

Resolved in #532

dtroupe-plaid avatar Jul 18 '23 17:07 dtroupe-plaid