pattern icon indicating copy to clipboard operation
pattern copied to clipboard

handleTransactionsWebhook.js missing case in switch statement

Open emagaram opened this issue 3 years ago • 3 comments

Hi, I believe the switch statement in handleTransactionsWebhook.js should include "TRANSACTIONS_REMOVED". Thanks!

emagaram avatar Sep 22 '22 04:09 emagaram

@emagaram thanks for the report! I believe the current switch statement is correct -- listening for the SYNC_UPDATES_AVAILABLE webhook effectively replaces the need to listen for TRANSACTIONS_REMOVED, as any removed transactions will be reported via SYNC_UPDATES_AVAILABLE.

phoenixy1 avatar Sep 22 '22 04:09 phoenixy1

That makes sense, but won't it log "unhandled webhook type received"?

emagaram avatar Sep 22 '22 04:09 emagaram

@emagaram hmm -- yes, I suppose it will!

phoenixy1 avatar Sep 22 '22 16:09 phoenixy1