Philippe Laferrière
Philippe Laferrière
When encountering a control block (e.g. `JOIN`), writing to the system and stack columns is [handled by calling `self.execute_op(Operation::Noop)`](https://github.com/0xPolygonMiden/miden-vm/blob/b2294a1e0e98af155d679dce082eb7fe3a04d9a2/processor/src/decoder/mod.rs#L337). This is unintuitive, makes debugging harder (e.g. a print inside `execute_op()`...
The following test fails with error `OutputStackOverflow(1)`, presumably because there were 2 `PUSH` instructions, and one `ADD` (which shifts stack left), and so the overflow table contains a 0 entry...
_Originally posted by @plafer in https://github.com/0xPolygonMiden/miden-vm/pull/1516#discussion_r1781552482_ > It seems like `DYN` could not issue any hash request, and also not have an associated `END`, since we're only hashing dummy values?...
Left to do: - [x] fix bug in `MidenLogUpGkrEval` - [x] Remove Op group table aux column & aux constraints - [ ] cleanup (i.e. address all `TODO(plafer)`
The current kernel ROM chiplet was designed with the assumption that it would be proved using a running product column (i.e. a "vanilla multiset check"). Specifically, if a program makes...
The kernel proc table in the [`ChipletsVTableColBuilder`](https://github.com/0xPolygonMiden/miden-vm/blob/6f60f74eaf2efd8825e77e698e0b8e1a4bc3cc95/processor/src/chiplets/aux_trace/mod.rs#L68) never includes any kernel procedure (i.e. `build_kernel_procedure_table_inclusions()` always returns `E::ONE`). This is also made clear by the fact that `AuxColumnBuilder::init_requests` doesn't initialize the...
_Originally posted by @bobbinth in https://github.com/0xPolygonMiden/miden-vm/pull/1482#discussion_r1751216993_ >Not for this PR, but I wonder if there is a way to refactor this so that all decorator-related data is in one section....
I'd like to suggest a refactoring of our various multiset checks; this will be necessary soon enough when we integrate them into LogUp-GKR anyways. The current abstractions we have couple...
_Originally posted by @bobbinth in https://github.com/0xPolygonMiden/miden-vm/pull/1466#discussion_r1744607413_ >Maybe not for this PR, but I wonder if we can modify the `DecoratorIterator` to return the actual decorators rather than decorator IDs. If...