Philippe Laferrière

Results 97 issues of Philippe Laferrière

As requested by @crodriguezvega, we should release docker images of basecoin so that ibc-go can add end-to-end tests with ibc-rs.

[Here](https://github.com/informalsystems/basecoin-rs/blob/4b41578acbbc4363dfc72613e12e75cfe733cff8/src/app/modules/ibc.rs#L727-L729). We only need to use the implementation [in ibc-rs](https://github.com/cosmos/ibc-rs/blob/0f3e03f84859d13cf842ec718eed3a2d8817a4d4/crates/ibc/src/clients/ics07_tendermint/host_helpers.rs#L19).

bug

The current `Store` API only [allows us](https://github.com/informalsystems/basecoin-rs/blob/d1a80e12002acd1dac5013f90a0c7c78dfec2d85/src/app/store/mod.rs#L176) to set serialized values. This is incompatible with the upcoming ibc v0.20.0 which implemented [ADR 4](https://github.com/cosmos/ibc-rs/blob/8bd8235405da649166aeddfcb653f7339bffff81/docs/architecture/adr-004-light-client-crates-extraction.md). Specifically, we would like to store `Box`...

enhancement

Currently, `From` and `TryFrom` implementations for `app::store::Path` are found in multiple files (`ibc.rs`, `auth.rs`, etc). All these should be moved in `src/app/store/mod.rs` next to the definition of `Path`, as it...

Currently, [`Module::init()`](https://github.com/informalsystems/basecoin-rs/blob/c1b0e097230c43394ee9cbc5bce01e1142ce7760/src/app/modules/mod.rs#L59) takes a `json` object as input. We should investigate how to make this type-safe. A rough sketch for a possibility would be: ```rust trait Module { type InitData;...

Currently, in the context of `Store`s, [we use `Path`](https://github.com/informalsystems/basecoin-rs/blob/c1b0e097230c43394ee9cbc5bce01e1142ce7760/src/app/store/mod.rs#L164) and [we use `Key`](https://github.com/informalsystems/basecoin-rs/blob/d1519cb897470284b7542cb464784d0bef133d71/src/app/store/mod.rs#L493) (here, `K` was chosen as a short for `Key`) both the signify the key to a value...

Currently the `Store` [stores objects of type `Vec`](https://github.com/informalsystems/basecoin-rs/blob/c1b0e097230c43394ee9cbc5bce01e1142ce7760/src/app/store/mod.rs#L164). This forces us to serialize/deserialize `Rust` types before putting them in a `Store`. We should investigate supporting storing predefined Rust types for...

### Description It would be great if the `tendermint-testgen` crate supported `no_std`. This is currently a [blocker in ibc-rs](https://github.com/cosmos/ibc-rs/pull/318#issuecomment-1373073729) for making our `mocks` feature `no_std`. ### Definition of "done" ```toml...

enhancement

In the repl, ``` >>> def farenheit(celsius) = celsius * 9 / 5 + 32 >>> def farenheit(celsius) = celsius * 9 / 5 + 32 syntax error: :4:1 -...

usability
feedback
repl
error messages