Philippe Laferrière

Results 97 issues of Philippe Laferrière

_Originally posted by @bobbinth in https://github.com/0xPolygonMiden/miden-vm/pull/1466#discussion_r1744348232_ >Using vectors here increases the size of this struct from 40 bytes to 88 bytes. This also means that the size of `MastNode` enum...

As discussed in https://github.com/0xPolygonMiden/miden-vm/pull/1480#pullrequestreview-2287458755, AIR constraints currently don't verify that `u32` values are $< 2^{32}$. We should enforce that in the constraints.

air

We should give the user the ability to receive warnings upon assembly that we judge are infrequent enough to not output on every build, but that could still be useful...

good first issue
assembly

As identified by @bobbinth, as of v0.10.3, the following fails: ``` use.miden::contracts::wallets::basic->basic_wallet export.basic_wallet::receive_asset export.basic_wallet::send_asset ``` Note that module aliases work fine (as enforced by [the `module_alias` test](https://github.com/0xPolygonMiden/miden-vm/blob/60ccf239fe9b77191d3c7173474daeacfd1f2ea4/assembly/src/tests.rs#L1827-L1870)); it is specifically...

bug
assembly

Context: https://github.com/0xPolygonMiden/miden-vm/pull/1445#discussion_r1713748940 and https://github.com/0xPolygonMiden/miden-vm/pull/1445#discussion_r1713778654 Currently, the `bundle` CLI command 1. creates a `Library` from a directory, and 2. automatically includes debug symbols. It would be great if both were configurable:...

good first issue

According to the [AUX column layout](https://github.com/0xPolygonMiden/miden-vm/blob/107142dc470a8130baf8a900a114e22eb08f2e9e/air/src/trace/mod.rs#L57-L92), we there is currently a hasher aux column. However, we [don't build](https://github.com/0xPolygonMiden/miden-vm/blob/107142dc470a8130baf8a900a114e22eb08f2e9e/processor/src/trace/mod.rs#L221-L226) any hasher aux column. According to @Al-Kindi-0, this is a leftover from...

air

The processor should ensure to always insert a `HALT` (even when no padding is needed). We should also have a boundary constraint that ensures that the last statement is a...

air