Philippe Laferrière

Difficulties building

5

I tried 2 different ways to build, and both failed. What am I doing wrong? On Ubuntu 20.04, x86_64. # Try 1 $ cargo build ... error[E0713]: borrow may still...

The type `ClientType` is not clearly defined in ICS-2, and seems to play 2 different roles. On the one hand, it is the type of the value stored at `"clients/{identifier}/clientType"`...

Connection `version` still defined with `string`: inconsistent with ibc-go

1

The connection version in the standard is inconsistent with what's being used in ibc-go. Specifically, in the standard, a version is an opaque `string`, whereas in ibc-go, it is as...

`Packet.timeoutHeight` should have type `Option<Height>` (or equivalent)

4

`Packet.timeoutHeight` treats the minimum height `0` specially: a height of `0` means "no timeout". This is taken from this check in `timeoutPacket()`: ```js abortTransactionUnless( (packet.timeoutHeight > 0 && proofHeight >=...

ICS-7 `Height` should specify height `0`

1

ICS-2 specifies that a `Height` must have a minimum element `0`. ICS-7 does not specify what `0` is. The two candidates that I see are 1. `Height { revisionNumber: 0,...

ICS4's `recvPacket()` currently aborts the transaction and emits no logs if the channel is ordered and the `sequence` number in the packet doesn't match the chain's `nextSequenceRecv`. However, ibc-go and...

ICS20: support base denoms with slashes

3

ibc-go [now supports base denoms with slashes](https://github.com/cosmos/ibc-go/pull/978). We should probably update the standard so that other implementations can also support [chains that require it](https://github.com/cosmos/ibc-go/issues/894). ibc-rs is planning on supporting base...

## Summary of Bug We currently don't output the same events as ibc-go (e.g. due to the extensive use of [default values](https://github.com/informalsystems/ibc-rs/blob/d9c6f897097315a6b67df063ec682f13b4cffbba/modules/src/core/ics04_channel/handler/chan_open_ack.rs#L95-L99)). # Acceptance criteria - All our handlers output...

## Summary `checkMisbehaviourAndUpdateState()` and corresponding handler, as defined in the standard, is missing. ## Problem Definition Handler to be implemented [here](https://github.com/informalsystems/ibc-rs/blob/5df35478607452baa8db004efb1d7aa38dfd8d89/modules/src/core/ics02_client/handler.rs#L28-L30), using a new `ClientDef::check_misbehaviour_and_update_state()` function. ____ #### For Admin...

Add an integration test for client upgrade

1

Can we add an integration test for client upgrade? Maybe in a different PR? _Originally posted by @ancazamfir in https://github.com/informalsystems/ibc-rs/issues/2304#issuecomment-1157811442_