Philippe Laferrière
Philippe Laferrière
This is very appreciated! We are working to merge the `al-simplify-aux` branch soon; I think we're pretty much ready to merge after https://github.com/0xPolygonMiden/miden-vm/pull/1214. So I would either wait for the...
Closing as stale.
@Overcastan Are you still working on this?
EDIT: I adjusted the section after discussing with @Al-Kindi-0 (which cleared up the remaining misunderstanding). It is now dedicated to explaining the "why" behind the Lagrange kernel's transition constraints as...
> Re-posting from Discord. Current resolution is we'll put this issue on hold until we find a better solution I'm almost done implementing this and just now realizing a fundamental...
#396 was a core IBC bug; not Tendermint-specific. Did you mean "core handler validation needs to be tested" instead of "Tendermint proof verifications"?
Ah I see; yes that's right.
After we refactor our errors with #269, each test should confirm that the right error was emitted as opposed to [using `Result::is_err()`](https://github.com/cosmos/ibc-rs/blob/0f3e03f84859d13cf842ec718eed3a2d8817a4d4/crates/ibc/src/core/ics04_channel/handler/timeout_on_close.rs#L431).
#430 implements all tests except for `RecvPacket`
A thought: ideally, internal functions that do use an `Error` enum would return an `Error` enum where the variants capture only the possible errors for that function. For example, [`verify_delay_passed()`](https://github.com/cosmos/ibc-rs/blob/3e139844c587ec96a7ca74f24128258b9880f2fb/crates/ibc/src/clients/ics07_tendermint/client_state.rs#L233-L259)'s...