Results 68 comments of Priit Laes

I would rather see smtc-modem-cores (together with -sys) shoul in a separate repository.

@lucasgranberg Grand plan is this - https://github.com/lora-rs/lora-rs/issues/126#issuecomment-2357778569 And as next step we can just replace generic-array with hybrid -array in single place.

Please add a test to show that sx126x network key is properly converted. Also, how about using enum? ```rust pub enum NetworkSyncWord { LoRaWanPublic, LoRaWanPrivate, MeshTastic, CustomNetwork(u8), } impl LoRaSyncWord...

> Will my changes be squashed into one commit when they are merged in? Which way do you want them?

> > I am not sure why this PR is just stuck in approved. Is there something else I need to do? > > We just have to agree on...

You need both dio0 and dio1 for sx1276 because lorawan-device uses `RxTimeout` IRQ: ![image](https://github.com/user-attachments/assets/9d352e41-fb54-4e37-8a9c-4cfe2d97598e) See pseudocode from this example: https://github.com/lora-rs/lora-rs/issues/262#issuecomment-2476016424 The example is broken because none of the currently active...

Yeah it's a bit tricky with examples because p2p works fine with only dio0. Probably best one can do is go over the all examples and mark the ones which...