reconnecting-websocket icon indicating copy to clipboard operation
reconnecting-websocket copied to clipboard

Buffering of messages while offline can now be toggled on/off via options...

Open beyond-code-github opened this issue 7 years ago • 6 comments

...for example when a service is already using a persistent queue

beyond-code-github avatar Nov 02 '18 09:11 beyond-code-github

FYI on checkout I had three test failures, perhaps this is down to my version of node/npm but just thought I would highlight it. Thanks for this project!

beyond-code-github avatar Nov 02 '18 09:11 beyond-code-github

Coverage Status

Coverage increased (+0.09%) to 94.415% when pulling 162ae556c60b6fdc64036946bd46f84694f38657 on beyond-code-github:buffer-while-offline-option into c64d32fbeaf70199e7b82817476f4d9f3e35ef39 on pladaria:master.

coveralls avatar Nov 02 '18 09:11 coveralls

As a heads up, I also added PR #97 that can support this by setting the queue size to 0, along with supporting other possible queue sizes

phil-flyclops avatar Nov 26 '18 19:11 phil-flyclops

hI, @beyond-code-github, does PR #97 solve your problem?

pladaria avatar Aug 29 '19 05:08 pladaria

@pladaria yup I think that would work just fine, happy to close this in light of #97 :)

beyond-code-github avatar Aug 30 '19 19:08 beyond-code-github

close?

bj00rn avatar Nov 07 '19 11:11 bj00rn