MobDebug icon indicating copy to clipboard operation
MobDebug copied to clipboard

Fix. Partial recv in debug loop

Open moteus opened this issue 3 years ago • 3 comments

Is there any guidlines for code style for this module? E.g. is it safe to decompose debug_loop function? Righ now I working on addition a new protocol and it will be much easily to do this if split protocol from implementation.

moteus avatar Jan 08 '22 17:01 moteus

Interesting; I don't think there are any strict guidelines, but it may be worthwhile to implement some basic protocol elements you want to add first (with the mobdebug changes you'd need) and then review/discuss those.

pkulchenko avatar Jan 08 '22 17:01 pkulchenko

I working on VSCode extension for ModDebug library. My main concerns is it safe to move lines like capture_vars(stack-1, coro_debugee) to a separate function.

moteus avatar Jan 08 '22 17:01 moteus

Yes, it may be possible to move it, but I suspect that stack-1 index will have to be adjusted accordingly for the depth added by the additional function calls.

pkulchenko avatar Jan 08 '22 17:01 pkulchenko