octonode icon indicating copy to clipboard operation
octonode copied to clipboard

Improve the CLI auth logic

Open ankon opened this issue 9 years ago • 4 comments

These are changes I needed for creating a desktop application using this library:

  1. Provide client_id, client_secret, note, note_url, and fingerprint in the authorization request
  2. Allow reusing an existing authorization

There is still one open issue here: github will return a hashed token and the last 8 characters when reusing a token, but these values are not provided to the callback, so the app cannot actually verify the token. I'll open a separate issue for that, as it might need incompatible changes to the API.

ankon avatar Feb 03 '16 10:02 ankon

Just a few comments which need to be addressed.

pksunkara avatar Feb 03 '16 18:02 pksunkara

@ankon Any update on this?

pksunkara avatar Nov 04 '16 10:11 pksunkara

@ankon Could you give an update on this?

pksunkara avatar Mar 03 '17 20:03 pksunkara

Oops, missed this. :/

I'm no longer using this library, so right now can not do any updates.

ankon avatar May 19 '17 12:05 ankon