script.artistslideshow icon indicating copy to clipboard operation
script.artistslideshow copied to clipboard

Need add Artist from internet streams

Open ziurim opened this issue 3 years ago • 7 comments

Hi,

I would like to make change https://github.com/pkscout/script.artistslideshow/blob/39b907e51ecfaf5d0281dbed515df9627d34bbf4/resources/lib/artistslideshow.py#L572 add Artist from internet radio streams, because using only song name something like this: playing_song = ' - '.join(iter(filter(None, [self.getMusicInfoTag().getArtist(), self.getMusicInfoTag().getTitle()]))) Thanks

ziurim avatar Mar 05 '21 16:03 ziurim

Internet stream addons (at least none I've ever seen) don't set the artist tag. Most of those get a single item from the stream originator and stick it in TITLE. So that change will do nothing. AS does attempt to parse the title for an artist using the convention of ARTIST - TITLE, and there is an option to also parse using TITLE - ARTIST in the settings.

pkscout avatar Mar 05 '21 16:03 pkscout

yes it was with Kodi 18.x Leia and works but with Kodi 19.x Matrix is splitted info

here is radio station sample http://82.135.234.195:8000/gerasfm.mp3 or https://stream.m-1.fm/m1/aacp64

code:

playing_title = self.getMusicInfoTag().getTitle()
LW.log(['playing_title: %s' % playing_title])
playing_artist = self.getMusicInfoTag().getArtist()
LW.log(['playing_artist: %s' % playing_artist])
playing_song = ' - '.join(iter(filter(None, [playing_artist, playing_title])))
LW.log(['playing_song: %s' % playing_song])

output:

2021-03-05 18:52:07.233 T:17618   DEBUG <general>: [Artist Slideshow] playing_title: Pure Intuition
2021-03-05 18:52:07.233 T:17618   DEBUG <general>: [Artist Slideshow] playing_artist: Shakira
2021-03-05 18:52:07.233 T:17618   DEBUG <general>: [Artist Slideshow] playing_song: Shakira - Pure Intuition

I tried with PVR and with Addon here is screenshots: Screenshot from 2021-03-05 18-51-16 Screenshot from 2021-03-05 18-51-41

maybe we can be find solution Thanks

ziurim avatar Mar 05 '21 17:03 ziurim

I'll take another look, but I think that behavior may be very stream dependent, so I'll have to build in some logic for fallback. Do you have an addon I can use to test? I'll see about getting the stream files to play directly, but that isn't something I do on any kind of regular basis.

pkscout avatar Mar 05 '21 17:03 pkscout

I'm not able to duplicate your issue. Using that first radio station sample (saved as a strm file and opened from the File Manager), the artist is showing on my skin in the artist field, and AS is downloding artist images just fine. I'm using Kodi 19.0 with the same version of AS available in the repo.

pkscout avatar Mar 05 '21 17:03 pkscout

I use: AS 3.3.0+matrix.1 Kodi 19 (2021-02-19 f44fdfbf67) Skin Estuary 3.0.5 (Default Kodi skin)

Addon I don't have for this time, I try to make it :) here is radio stations playlist you can add to PVR IPTV Simple Client

stations with song information: Geras FM, M-1, M-1 Plius, Radio Centras, Gold FM, European Hit Radio, Rock FM, Extra FM

Thanks

ziurim avatar Mar 05 '21 17:03 ziurim

Maybe exists some news

ziurim avatar Mar 22 '21 08:03 ziurim

No news. I have other pressing projects that have required my attention, so I haven't had time to look at this. When there is a beta available I will post something to the Kodi forum about it at https://forum.kodi.tv/showthread.php?tid=124880.

pkscout avatar Mar 22 '21 15:03 pkscout