node-png icon indicating copy to clipboard operation
node-png copied to clipboard

cannot build under nodejs v4.1.2 with node-gyp v3.0.3

Open guodong opened this issue 9 years ago • 5 comments

cannot build under nodejs v4.1.2 with node-gyp v3.0.3

guodong avatar Oct 09 '15 03:10 guodong

gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | linux | x64
gyp info spawn python2
gyp info spawn args [ '/usr/lib/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/home/ubuntu/cloudware-ws/png/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/usr/lib/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/home/ubuntu/.node-gyp/4.1.2/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/home/ubuntu/.node-gyp/4.1.2',
gyp info spawn args   '-Dnode_gyp_dir=/usr/lib/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=node.lib',
gyp info spawn args   '-Dmodule_root_dir=/home/ubuntu/cloudware-ws/png',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.' ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory `/home/ubuntu/cloudware-ws/png/build'
  CXX(target) Release/obj.target/png/src/common.o
In file included from /home/ubuntu/.node-gyp/4.1.2/include/node/node.h:42:0,
                 from ../src/common.h:4,
                 from ../src/common.cpp:3:
/home/ubuntu/.node-gyp/4.1.2/include/node/v8.h: In function ‘v8::Handle<v8::Value> ErrorException(const char*)’:
/home/ubuntu/.node-gyp/4.1.2/include/node/v8.h:885:13: error: ‘v8::HandleScope::HandleScope()’ is protected
   V8_INLINE HandleScope() {}
             ^
../src/common.cpp:10:17: error: within this context
     HandleScope scope;
                 ^
../src/common.cpp:11:29: error: ‘New’ is not a member of ‘v8::String’
     return Exception::Error(String::New(msg));
                             ^
In file included from /home/ubuntu/.node-gyp/4.1.2/include/node/node.h:42:0,
                 from ../src/common.h:4,
                 from ../src/common.cpp:3:
/home/ubuntu/.node-gyp/4.1.2/include/node/v8.h: In function ‘v8::Handle<v8::Value> VException(const char*)’:
/home/ubuntu/.node-gyp/4.1.2/include/node/v8.h:885:13: error: ‘v8::HandleScope::HandleScope()’ is protected
   V8_INLINE HandleScope() {}
             ^
../src/common.cpp:16:17: error: within this context
     HandleScope scope;
                 ^
../src/common.cpp:17:46: error: ‘ThrowException’ was not declared in this scope
     return ThrowException(ErrorException(msg));
                                              ^
../src/common.cpp: In function ‘v8::Handle<v8::Value> ErrorException(const char*)’:
../src/common.cpp:12:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
../src/common.cpp: In function ‘v8::Handle<v8::Value> VException(const char*)’:
../src/common.cpp:18:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make: *** [Release/obj.target/png/src/common.o] Error 1
make: Leaving directory `/home/ubuntu/cloudware-ws/png/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 3.13.0-63-generic
gyp ERR! command "/usr/bin/nodejs" "/usr/bin/node-gyp" "configure" "build"
gyp ERR! cwd /home/ubuntu/cloudware-ws/png
gyp ERR! node -v v4.1.2
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok 

guodong avatar Oct 09 '15 03:10 guodong

Same here.

  • node 4.2.3;
  • node-gyp 3.0.3.

vladmyr avatar Dec 13 '15 19:12 vladmyr

Same here, subscribing this issue, looking forward for updates :D

daviddias avatar Jan 02 '16 20:01 daviddias

There's a load of changes that went into node in v0.12 and above (see here for example). I took a quick look at the code and it's a reasonably large change to support newer nodes as well as older ones.

mattgodbolt avatar Jul 23 '16 22:07 mattgodbolt

So it won't be supported ?

GuillaumeLeclerc avatar Aug 09 '16 22:08 GuillaumeLeclerc