[GDPR] | Invite to a role - Various pages, covers some UI related bugs

[Tribunal33]

Valid Title

• [x] I have updated the title to accurately reflect the bug description

Description

I appologize for not writting them all down individually but it made more sense this way. I did not write out the full steps but they should be clear at a high level. The following UI related bugs are addressed in this ticket

• [ ] Manditory fields not going away after filling in blank field with valid input (screenshot 1)
• [ ] Initial Role missing Remove Role button or when adding additional Roles it should not have the Remove Role button (Clarification on requirements) > (screenshot 1)
• [ ] Invitation Sent popup is not the success modal and some spelling issues (Screenshot 2)
• [ ] Remove Role from Previous accepted role has gramatical error (Screenshot 3) <-- could not find requirements but seemed wrong.
• [ ] Accepted invitation modal does not match figma designs (Screenshot 4)

Steps to Reproduce

Part 1 Manditory fields not going away...

1. Login with user and role with access to invite to a role
2. Navigate to Users & Roles page
3. Invite an existing user to a new role (ex dbarnes)
4. Do not enter any fields and Select Save and Continue to display field warnings
5. Select a new role, set a start date, and select a Masthead decision Expected : After each field has been assigned a valid input the warning should be removed Actual : See screenshot 1

Part 2 Initial Role missing...

1. Login with user and Navigate to Users and Roles page
2. Invite an existing user (ex dbarnes)
3. Select a role, date and Journal masthead decision
4. Select Add Another role Expected: Either the initial row should have a remove role button or the subsequent roles should not have a remove role button Actual : See screenshot 1

Part 3 - Invitation Sent Popup

1. Invite a user to a role
2. At the email stage Select Invite User to the role Expected: Success modal with checkmark and User and Role should be Users & Roles Actual : See screenshot 2

Part 4 - Remove role from previous...

1. Invite an existing user with multiple roles
2. Remove one of the roles Expected: Pop up seems to have grammatical issues. Suggestion is to change to "Are you sure you want to remove this role permanently?" Actual : See screenshot 3

Part 5 - Accepted Invitation modal....

1. Invite a user to a role
2. Have this user accept the invite from the email
3. Once the workflow is complete observe the popup modal Expected: Figma design wording with specific role mentioned Actual : See screenshot 4

Expected Result

Expected results are given in the steps for each part

Actual Result

Actual results are in screenshots below

Environment Details

No response

Application Version

OJS stable-3_5_0

Logs

No response

Additional Information

Screenshot 1 - Manditory field warnings and missing Remove Role button

Screenshot 2 - Invitation sent modal with formatting issues

Screenshot 3 - Wording seems off for Remove Role Popup. Suggestion would be > "Are you sure you want to remove this role permanently?"

Screenshot 4 - Success modal for accepted invitation has generic role message rather than specific role message and does not match figma designs

[Devika008]

Hi @Tribunal33

Here are my comments on the issues you have raised

Part 1 Manditory fields not going away...

The way suggested by you here are right

Part 2 Initial Role missing...

A "Remove" button should be included for all roles to allow easy removal of added roles. Without this option, undoing selections becomes difficult, violating the UX principle of "User Control and Freedom."

Part 3 - Invitation Sent Popup

​Previously, due to challenges in maintaining consistent color usage, we decided to standardize some elements in blue, omitting green accents. However, incorporating a check mark could enhance user experience by providing clear visual feedback.

Part 4 - Remove role from previous...

I had mentioned a copy in the issue #10895 however I am not able to access the issue. The copy was: "Are you sure you want to permanently remove this role? This action will revoke the user's access to all information and permissions associated with this role."

Part 5 - Accepted Invitation modal....

Introducing the copy mentioned on Figma would be a greta addition however, its not a deal breaker. Would put this change with least prioritiy

[ipula]

Hi @Devika008 @Tribunal33

Part 5

As I remembered that we decided to remove roles that user accepted. Because it there are more roles ,the title will be large and description will be also large

[Tribunal33]

@ipula Just one issue. Part 2, I still see the initial row missing a remove role button, however if you select Add Another role the button pops up.

[ipula]

@Tribunal33 when inviting user at least there is one role needs to be selected . That's why initial row does not have remove role button

[Tribunal33]

This passes QA. Had a meeting about the missing button Part 2 and adding a new requirement for it in another ticket. It is functionioning as expected.