pkp
[GDPR] | Invite to a role - Add role, Cannot add previously removed roles back
Valid Title
- [x] I have updated the title to accurately reflect the bug description
Description
Don't know if this was a requirement somewhere but I couldn't find it in figma or the parent ticket. If a user has been removed from the role and we want to add back that role there isn't a way to do it. It does not appear in the list of roles to select for an invitation. This can be seen in the invitation workflow or the user table workflow. We will focus on the invitation workflow.
Preconditions: Have a role removed from an existing user
Steps to Reproduce
- Login with user who can invite a user to a role
- Navigate to Users & Roles
- Invite a user to a role
- Input the username or email that has the role removed from the Journal (example used was Dbarnes > removed Journal Editor Role)
- Try to select this new role that was previously removed from the dropdown menu (example is Journal Editor for Dbarnes)
Expected Result
The role should be able to selected as a role to be invited from. The normal invite user to a role workflow should continue.
Once this role is accepted I would keep a record of the previous role with the end date as normal. On the user table maybe that would be overwritten with the new role and start date?
Actual Result
Cannot select the user role that was previously removed from the select a new role (step 2 page).
Environment Details
No response
Application Version
OJS stable-3_5_0
Logs
No response
Additional Information
This aspect wasn't part of our initial requirements discussion. However, I believe we should not restrict the Editor or Journal Manager from reassigning a user to a previously removed role, as Beau mentioned above. Allowing this flexibility ensures smoother role management and aligns with best practices in user administration.
This passes QA. Was able to add back previous role even within the same invitation. You are still able to select the initial role but you get a proper warning.