pkp-lib icon indicating copy to clipboard operation
pkp-lib copied to clipboard
verified publisher icon pkp

Redesigned Dashboard - Editorial activity

Open jardakotesovec opened this issue 1 year ago • 1 comments

Only known issue - date when the submission is confirmed by editor is not displayed. That should start working once the subissue https://github.com/pkp/pkp-lib/issues/10359 gets merged, which should be soon.

All editorial status scenarios are mocked in storybook and should be good source of the truth. Links are below for individual roles.

Individual review assignment indicators are covered here.

For Editor, Deciding Editor, Recommend only editor and Author - all the scenarios are the same - just being seen through different role.

Reviewer is getting list of reviewer assignments, where only his reviewer assignment status is relevant - therefore it has its own scenarios.

Editor

Deciding Editor

  • storybook
  • If recommend only editor is assigned. Than other editors who don't have the 'recommend only' flag are considered as deciding editors, who is supposed to make editorial decision once the recommendations are posted from recommend only editors.
  • Intention for such user is to reduce the unnecessary details of individual reviews. And just inform them when recommendations are ready to work with.

Recommend Only Editor

  • storybook
  • User who is making recommendations for final editorial decision. Intention for him is to have same experience as normal editor. Therefore the statuses, that are specific for recommending scenarios (REVIEW_ROUND_STATUS_PENDING_RECOMMENDATIONS, REVIEW_ROUND_STATUS_RECOMMENDATIONS_READY, REVIEW_ROUND_STATUS_RECOMMENDATIONS_COMPLETED) will display individual review assignments, instead of these statuses.

Author

  • storybook
  • author should not see individual reviewers unless its open review, scenario 17 covers opened reviews.

Reviewer

  • storybook
  • reviewer see instruction based on the review assignment status

jardakotesovec avatar Dec 10 '24 14:12 jardakotesovec

Have dropped my feedback here: https://mattermost.publicknowledgeproject.org/pkp/pl/u7ejccn3ki8i7re4kxyeyyf3hy

Devika008 avatar Feb 11 '25 17:02 Devika008

This passes QA. Hard to know what to test for expectations. Based the requirements on what has been completed and seen in storybook. A lot of these scenarios were communicated over several meetings so I will assume to be working and from here on be the expected outcomes.

Test case summary

  1. Test the editorial activity icon - Awaiting Response
  2. Test the editorial activity icon - Declined
  3. Test the editorial activity icon - Response Overdue
  4. Test the editorial activity icon - Accepted
  5. Test the editorial activity icon - Review Overdue
  6. Test the editorial activity icon - Received
  7. Test the editorial activity icon - Viewed
  8. Test the editorial activity icon - Complete
  9. Test the editorial activity icon - Thanked
  10. Test the editorial activity icon - Cancelled
  11. Test the editorial activity icon - Request Resend
  12. Test the editorial activity message for Scheduled
  13. Test editorial activity message Incomplete submission
  14. Test editorial activity message Declined submission
  15. Test editorial activity message Submission stage
  16. Test editorial activity message Submission stage - no editors assigned
  17. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_REVISIONS_REQUESTED: Revisions requested for the ame round
  18. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_RESUBMIT_FOR_REVIEW: Revisions requested, to be used in next round
  19. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_PENDING_REVIEWERS: No reviewers have been assigned
  20. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_PENDING_REVIEWS: Waiting for reviews to be submitted by reviewers
  21. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_REVIEWS_READY: One or more reviews is ready for an editor to view
  22. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_REVIEWS_COMPLETED: All assigned reviews have been confirmed by an editor
  23. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_REVIEWS_OVERDUE: One or more reviews is overdue
  24. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_REVISIONS_SUBMITTED: at least one revision file has been uploaded
  25. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_RESUBMIT_FOR_REVIEW_SUBMITTED: at least one revision file has been uploaded.
  26. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_RETURNED_TO_REVIEW:The following status is set when a submission return back from copyediting stage to last review round again
  27. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_PENDING_RECOMMENDATIONS: Waiting for recommendations to be submitted by recommendOnly editors
  28. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_RECOMMENDATIONS_READY: One or more recommendations are ready for an editor to view
  29. Test editorial activity message Review stage - REVIEW_ROUND_STATUS_RECOMMENDATIONS_COMPLETED: All assigned recommendOnly editors have made a recommendation
  30. Test editorial activity message Review stage - Recommend only editor provided recommendation (relevant only for recommend only editor)
  31. Test editorial activity message Review stage - Open reviews
  32. Test editorial activity message Copyediting stage
  33. Test editorial activity message Production stage
  34. Test editorial activity message Production stage - Published
  35. Test editorial activity message as author for Review stage - Open reviews
  36. Test editorial activity message as author for Review stage - REVIEW_ROUND_STATUS_REVISIONS_REQUESTED: Revisions requested for the same round
  37. Test editorial activity message as author for Declined submission
  38. Test editorial activity message as author for Review stage - all other states
  39. Test editorial activity message as Deciding Editor for Review stage - all other states
  40. Test editorial activity message as Recommending Editor for Review stage - REVIEW_ROUND_STATUS_PENDING_RECOMMENDATIONS: Waiting for recommendations to be submitted by recommendOnly editors
  41. Test editorial activity message as Recommending Editor for Review stage - REVIEW_ROUND_STATUS_RECOMMENDATIONS_READY: One or more recommendations are ready for an editor to view
  42. Test editorial activity message as Recommending Editor for Review stage - REVIEW_ROUND_STATUS_RECOMMENDATIONS_COMPLETED: All assigned recommendOnly editors have made a recommendation
  43. Test editorial activity message as Recommending Editor for Review stage - Recommend only editor provided recommendation
  44. Test editorial activity message as a Reviewer for Review status - Awaiting Response
  45. Test editorial activity message as a Reviewer for Review status - Declined
  46. Test editorial activity message as a Reviewer for Review status - Response overdue
  47. Test editorial activity message as a Reviewer for Review status - Accepted
  48. Test editorial activity message as a Reviewer for Review status - Review overdue
  49. Test editorial activity message as a Reviewer for Review status - Received
  50. Test editorial activity message as a Reviewer for Review status - Completed
  51. Test editorial activity message as a Reviewer for Review status - Thanked
  52. Test editorial activity message as a Reviewer for Review status - Request Resend
  53. Test editorial activity message as a Reviewer for Review status - Viewed
  54. Test editorial activity message as a Reviewer for Review status - Accepted when moved to copyedit or production stage
  55. Test editorial activity message as a Reviewer for Review status - Declined when moved to copyedit or production stage
  56. Test editorial activity message as a Reviewer for Review status - Cancelled

Tribunal33 avatar Mar 26 '25 19:03 Tribunal33