omp icon indicating copy to clipboard operation
omp copied to clipboard

pkp/omp#6081 Fix stacking of not-featured/featured titles in catalog

Open alexdryden opened this issue 4 years ago • 5 comments

Fix how titles stack in the catalog when the top title is not featured and the second title is featured.

alexdryden avatar Jul 11 '20 00:07 alexdryden

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 11 '20 00:07 CLAassistant

Thanks, @alexdryden! @NateWr, would you mind giving this a quick look over?

asmecher avatar Jul 11 '20 00:07 asmecher

Thanks @alexdryden! Do you have an example where I can see this problem occurring? Your CSS code looks good, but the situation you describe should never happen. Featured titles should always appear before not-featured titles in the catalog. It seems like the ordering code is not working:

https://github.com/pkp/omp/blob/master/classes/services/queryBuilders/SubmissionQueryBuilder.inc.php#L98-L127

If we can confirm this, I can file that as an issue at https://github.com/pkp/pkp-lib/issues/ and we can get a fix for that out with the next release.

NateWr avatar Jul 13 '20 14:07 NateWr

@NateWr I agree, I the real issue is the ordering logic. I originally filed this issue about it. Here is an example it in our sandbox (with the css fix applied).

alexdryden avatar Jul 13 '20 14:07 alexdryden

Ah, I see that you're getting passed between Alec and I on this one. I think this is worth fixing at the source. I'll follow up in the issue.

NateWr avatar Jul 13 '20 15:07 NateWr