bootstrap3 icon indicating copy to clipboard operation
bootstrap3 copied to clipboard

Readable theme contains not readable color selection

Open dogsleg opened this issue 3 years ago • 1 comments

Hi,

thanks for your work on Bootstrap Theme for OJS.

Readable theme has a color selection for "Make a new submission or view your pending submissions". Please, see the screenshot attached.

Readable

dogsleg avatar Sep 24 '22 16:09 dogsleg

Thanks for reporting this @dogsleg. I don't have time to address this now but I will try to get a fix for this in when a refactor the theme for 3.4.

NateWr avatar Oct 03 '22 09:10 NateWr

Fix ready for this, which will add the alert-link class to links in alert boxes. This improves the display of links across all of the sub-styles as well.

Readable theme with fix (see screenshot above for before):

Screenshot 2024-06-27 at 11 31 46 AM

Alerts for user registration form before (Readable theme):

Screenshot 2024-06-27 at 11 40 13 AM

Alerts for user registration form with fix (Readable theme):

Screenshot 2024-06-27 at 11 39 54 AM

@asmecher PR ready for review - will forward-port if all looks good:

  • 3_3_0: https://github.com/pkp/bootstrap3/pull/215
  • 3_4_0: https://github.com/pkp/bootstrap3/pull/218
  • main: https://github.com/pkp/bootstrap3/pull/219

kaitlinnewson avatar Jun 27 '24 14:06 kaitlinnewson

^ Merged, thanks, @kaitlinnewson!

asmecher avatar Jun 27 '24 19:06 asmecher

@asmecher Additional PRs linked above and ready for review.

kaitlinnewson avatar Jun 27 '24 19:06 kaitlinnewson

Both merged, thanks! Now that you've got permissions on this repo, you can use your discretion to decide whether ports need additional review; if not, feel free to git cherry-pick them forward.

asmecher avatar Jun 27 '24 19:06 asmecher