bootstrap3 icon indicating copy to clipboard operation
bootstrap3 copied to clipboard

Copyright Notice - edit link broken

Open israelcefrin opened this issue 4 years ago • 4 comments

When a logged user attempts to edit "Copyright Notice" section, clicking on "edit" link from frontend interface, it takes the user to a blank screen.

The reason is pointing to: /management/settings/journal#policies when the correct link should be: /management/settings/distribution#permissions

The edit link is shown in "Submission" page of the journal.

image

israelcefrin avatar May 28 '21 20:05 israelcefrin

What version of OJS and Bootstrap3?

NateWr avatar May 31 '21 09:05 NateWr

OJS version: 3.1.1.0 Bootstrap: 1.1.4.0

israelcefrin avatar May 31 '21 14:05 israelcefrin

I don't think that we'll fix it for 3.1.x. can you reproduce the problem in 3.3.x?

On Mon, 31 May 2021, 15:18 Israel Cefrin, @.***> wrote:

OJS version: 3.1.1.0 Bootstrap: 1.1.4.0

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NateWr/bootstrap3/issues/169#issuecomment-851521859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARTERIFKJJB3CHVK3CCZHTTQOLDRANCNFSM45XNK7BQ .

NateWr avatar Jun 01 '21 09:06 NateWr

OJS 3.3 shows similar issues using the Bootstrap theme. I've tested on the test-drive install:

https://demo.publicknowledgeproject.org/ojs3/testdrive/index.php/testdrive-journal/about/submissions

There is not a "copyright notice", but either "Submission Preparation Checklist " and "Author Guidelines" are showing broken links when logged.

israelcefrin avatar Jun 01 '21 20:06 israelcefrin

@asmecher I have a small change ready for review to fix this - will forward-port if all looks good:

  • 3_3_0: https://github.com/pkp/bootstrap3/pull/209
  • 3_4_0: https://github.com/pkp/bootstrap3/pull/210
  • main: https://github.com/pkp/bootstrap3/pull/211

kaitlinnewson avatar Jun 24 '24 17:06 kaitlinnewson

Merged, thanks -- please go ahead!

asmecher avatar Jun 24 '24 19:06 asmecher

@asmecher Additional PRs ready for merge and linked above.

kaitlinnewson avatar Jun 24 '24 23:06 kaitlinnewson

Merged, thanks, @kaitlinnewson! Is this ready to be closed?

asmecher avatar Jun 25 '24 19:06 asmecher

@asmecher Yes, ready to close!

kaitlinnewson avatar Jun 25 '24 19:06 kaitlinnewson

Thanks!

asmecher avatar Jun 25 '24 19:06 asmecher