bootstrap3 icon indicating copy to clipboard operation
bootstrap3 copied to clipboard

The getLocalizedSubject() function is returning error

Open israelcefrin opened this issue 5 years ago • 1 comments

Hi @NateWr

I've enabled the bootstrap3 theme in a Brazilian portugueses journal, this journal accepts submissions in English, however there is none so far. All site seems to work fine but the article detail page is not loading. Checking the logs I've found out that the following code in is preventing the journal to show the page: https://github.com/NateWr/bootstrap3/blob/master/templates/frontend/objects/article_details.tpl#L230

The log file shows :

PHP Fatal error: Uncaught Error: Call to undefined method PublishedArticle::getLocalizedSubject()

I can see tha there is a verification whether getLocalizedSubject is true, but the system is returning a non-existent method. Is it safe to remove this chunk from the theme?

Best, Israel

israelcefrin avatar Sep 09 '19 13:09 israelcefrin

I recently merged a change that got rid of the getLocalizedSubject function. It wasn't working and wasn't used in the OJS codebase, but I didn't check plugins. Your PRs to resolve this look good to me!

asmecher avatar Sep 09 '19 16:09 asmecher

@asmecher This issue can be closed (resolved in https://github.com/pkp/bootstrap3/pull/136).

kaitlinnewson avatar Jun 24 '24 23:06 kaitlinnewson

Closing, thanks!

asmecher avatar Jun 25 '24 19:06 asmecher