bootstrap3 icon indicating copy to clipboard operation
bootstrap3 copied to clipboard

Language block in the sidebar not displaying correctly

Open israelcefrin opened this issue 6 years ago • 1 comments

The language block in the sidebar is not displaying correctly in a multi-journal installation when set to be used in the portal home.

It seems that the container is now getting the width from the inner content. Please see the image.

bootstrap-language-block

israelcefrin avatar Jul 15 '19 17:07 israelcefrin

Ran into this issue today. It seems the breaking change is that the wrapping for the header "Language" is now a h2 tag rather than a span tag.

andjsmit avatar Jun 30 '20 17:06 andjsmit

In OJS 3.3 I can only reproduce this in the "small" breakpoint in bootstrap (width 768-991). I've made a minor adjustment to the breakpoint. This will also resolve https://github.com/pkp/bootstrap3/issues/180.

PR ready for review @asmecher:

  • 3_3_0: https://github.com/pkp/bootstrap3/pull/212
  • 3_4_0: https://github.com/pkp/bootstrap3/pull/213
  • main: https://github.com/pkp/bootstrap3/pull/214

Display before change:

Screenshot 2024-06-26 at 10 18 09 AM

Display after change:

Screenshot 2024-06-26 at 10 31 40 AM

kaitlinnewson avatar Jun 26 '24 13:06 kaitlinnewson

Thanks, @kaitlinnewson, I've merged https://github.com/pkp/bootstrap3/pull/212. Does this need forward-porting?

asmecher avatar Jun 26 '24 23:06 asmecher

@asmecher Additional PRs added above and ready for review/merge.

kaitlinnewson avatar Jun 27 '24 12:06 kaitlinnewson

Merged both, thanks -- closing!

asmecher avatar Jun 27 '24 19:06 asmecher