jscroll Do not self destroys when there is only one page

Do not self destroys when there is only one page

Open hemanth7787 opened this issue 10 years ago • 7 comments

Simple test to reproduce the results
jquery :1.9.1
jscroll:  v2.2.4

<html>
<body>

<div class="scroll">
    <h3>Page 1</h3>
    <p>Content here...</p>
  <a >next</a>
</div>

<script src="js/jquery-1.9.1.min.js"></script>
<script src="js/jquery.jscroll.min.js"></script>
<script type="text/javascript">
$('.scroll').jscroll({
  loadingHtml: '<a>loading...</a>',
});

 </script>
</body>
 </html>


It will show loading... , if  "loadingHtml" is a gif animation it plays indefinitely.

Thanks for creating a great jquery plugin

Apr 30 '14 11:04 hemanth7787

I have the same issue. Did you solve it?

Sep 23 '14 16:09 kopes18

index 829bdb7..5287a9d 100644
--- a/jquery.jscroll.js
+++ b/jquery.jscroll.js
@@ -43,6 +43,10 @@
             _$scroll = _isWindow ? _$window : $e,
             _nextHref = $.trim(_$next.attr('href') + ' ' + _options.contentSelector);

+        if (_$next.length == 0) {
+            return $e;
+        }
+
         // Initialization
         $e.data('jscroll', $.extend({}, _data, {initialized: true, waiting: false, nextHref: _nextHref}));
         _wrapInnerContent();