jscroll
jscroll copied to clipboard
pklauzinski
Added AMD support
Can you add "fix #114" to the pr description in order to link this pr properly to the issue?
Done
On Mon, Mar 27, 2017 at 6:27 PM, Klaus [email protected] wrote:
Can you add "fix #114 https://github.com/pklauzinski/jscroll/issues/114" to link this pr properly to the issue?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pklauzinski/jscroll/pull/124#issuecomment-289445216, or mute the thread https://github.com/notifications/unsubscribe-auth/AWbVF7YBjpwPfQRf-Cjyqfly1WN9pRUEks5rp7IigaJpZM4MBU79 .
Hey guys, what about this PR?
I would need it for a project using npm and webpack
i'm using the branch from @gs-rpal because I need CommonJS support for webpack. I've put the require('jscroll') before the plugin call and jquery.jscroll is included in the bundle source. However, the dependency isn't resolved and i get Uncaught TypeError: $(...).jscroll is not a function. Shouldn't it be compatible with webpack?
@dotmagic I managed to have the exact need, released a fork version that you may try it out. Feel free to report issues.
@ratson I'm not sure its a good idea to create a fork with almost same name but lower the version to 0.0.2? I think its confusing. @pklauzinski is still active on this project and it looks like he still welcome contributions.
I'm using CommonJS or ES6 imports now, I believe we should enhance the pull request to support all this types. Soon bower will disappear and we are going to manage scripts with yarn/webpack, for that reason I consider this feature essential.