pkgx icon indicating copy to clipboard operation
pkgx copied to clipboard

Shellcode for fish

Open mxcl opened this issue 1 year ago • 9 comments

Refs #704

mxcl avatar Oct 27 '23 12:10 mxcl

Pull Request Test Coverage Report for Build 6667484083

  • 15 of 27 (55.56%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 96.222%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modes/shellcode.ts 15 27 55.56%
<!-- Total: 15 27
Totals Coverage Status
Change from base Build 6653611079: -0.7%
Covered Lines: 1392
Relevant Lines: 1441

💛 - Coveralls

coveralls avatar Oct 27 '23 12:10 coveralls

@mxcl Don't forget this :)

FlatMapIO avatar Nov 24 '23 14:11 FlatMapIO

Very eager for this~

yoroshikun avatar Dec 04 '23 04:12 yoroshikun

@mxcl let us know if you need any testers for this! Looking forward to seeing this merged.

joshmedeski avatar Jan 18 '24 05:01 joshmedeski

I think I need to refactor the shellcode and other related pieces before this will be maintainable. I don't use fish (only because in general I stick with defaults so that I know what most of my users deal with on a day to day basis) and as a result it would be easy for it to end up breaking unless the underlying infra is solid.

Also not knowing fish it's hard to write. I am mostly using ChatGPT to translate.

mxcl avatar Jan 18 '24 12:01 mxcl

@mxcl Do you have anything in specific about how I might be able to help?

netzhuffle avatar Jan 18 '24 16:01 netzhuffle

@mxcl I've got fish scripting experience too, let us know if you want support.

joshmedeski avatar Jan 18 '24 16:01 joshmedeski

I'm at your service too, @mxcl. Looking forward to fish support

amok avatar Jan 18 '24 16:01 amok

This would help contributing to the pantry, as it relies on integration https://github.com/pkgxdev/pantry?tab=readme-ov-file#contributing

aybabtme avatar Sep 04 '24 04:09 aybabtme