pkgx icon indicating copy to clipboard operation
pkgx copied to clipboard

Issue 167 arg0 magic

Open magnusviri opened this issue 2 years ago • 2 comments

This includes PR https://github.com/teaxyz/cli/pull/190 and so that PR should probably be closed. IDK.

Anyway, I guess this implements https://github.com/teaxyz/cli/issues/167. It was easier than I thought (because you already added tea_foo).

magnusviri avatar Nov 22 '22 04:11 magnusviri

This only half completes 167 because it doesn't include the version stuff.

magnusviri avatar Nov 22 '22 05:11 magnusviri

  • ...etc... (up to 10)

what-the-diff[bot] avatar Nov 23 '22 06:11 what-the-diff[bot]

To request a re-review, you would click the "refresh" symbol next to the reviewer in question (mxcl, in this case).

jhheider avatar Nov 25 '22 03:11 jhheider

This isn't working for me. I keep getting loops. I think https://github.com/teaxyz/cli/issues/199 is worse than I thought.

magnusviri avatar Nov 25 '22 21:11 magnusviri

k this doesn’t work because -X foo uses foo from the path if it finds it rather than looks for a package.

Can fix by making -X not do that (which honestly maybe is the correct choice) or making -X not call foo if it's a symlink to tea (which honestly we should also do). Coming up.

mxcl avatar Nov 26 '22 14:11 mxcl

k fixed in next release, Gratz on this excellent contribution!

mxcl avatar Nov 26 '22 14:11 mxcl

Very excited! Time to replace stuff!

magnusviri avatar Nov 27 '22 22:11 magnusviri