ossapp icon indicating copy to clipboard operation
ossapp copied to clipboard

Clean Up Layout on Package Details View

Open tsmitty11 opened this issue 2 years ago • 10 comments

I have a more up-to-date design that takes all of the buttons into consideration and rearranges them into a more appealing layout. Please let @tsmitty11 if you have any questions as it relates to the design.

Screen Shot 2023-06-06 at 4 11 28 PM

tsmitty11 avatar Jun 06 '23 15:06 tsmitty11

@tsmitty11 the in-app-terminal pr for SD has been merged, this need to be updated.

getneil avatar Jul 18 '23 00:07 getneil

@getneil thanks Neil, I'll update with a new design.

tsmitty11 avatar Jul 18 '23 21:07 tsmitty11

Here's a Loom video. I think @mxcl intended for the tabs to open the cli and gui respectively, so we can probably omit the 'open in terminal' button... but he can confirm yay or nay.

https://www.loom.com/share/978f8e766fd043908d50702b2c9a186e?sid=5fe72fd6-f215-4761-aa4e-b5dd14a77723

Assuming that's the case, here's the install state:

Screen Shot 2023-07-18 at 11 28 50 PM

And the installed/update state:

Screen Shot 2023-07-18 at 11 28 59 PM

tsmitty11 avatar Jul 18 '23 22:07 tsmitty11

we shouldn't omit the open button it's the major CTA and should be positioned accoringly

mxcl avatar Jul 21 '23 11:07 mxcl

Screenshot 2023-07-21 at 10 16 34 AM

can we ensure that the layout at the default size the app opens at on clean installs involves no wrap? Thanks

mxcl avatar Jul 21 '23 14:07 mxcl

@mxcl thoughts on this? Leaves more horizontal space for the CTA lockup. Also allows a bit flexibility for the description text as it's confined to it's own row here.

Screen Shot 2023-07-21 at 7 21 04 PM

tsmitty11 avatar Jul 21 '23 18:07 tsmitty11

No text next to button; re: good point from Alan

Screen Shot 2023-07-21 at 7 34 48 PM

tsmitty11 avatar Jul 21 '23 18:07 tsmitty11

superb. approved

mxcl avatar Jul 23 '23 18:07 mxcl

@getneil @ABevier pushing this to top, as issue was technically closed. See above for details design approved by mxcl.

https://www.figma.com/file/UZJ2CrxsoX0pkhEY4NZE5j/GUI-Master?type=design&node-id=749%3A3619&mode=dev

tsmitty11 avatar Jul 24 '23 14:07 tsmitty11

sorry about that it was linked to a PR. that was merged

getneil avatar Jul 24 '23 14:07 getneil