libpkgx icon indicating copy to clipboard operation
libpkgx copied to clipboard

all configurable PKGX_DIST_URL

Open jhheider opened this issue 1 year ago • 5 comments

closes #71

jhheider avatar May 10 '24 14:05 jhheider

i don't see where this change would have made unicode's package.yml unparseable... @mxcl does this look like some other regression to you?

jhheider avatar May 10 '24 15:05 jhheider

Yeah cannot be due to this change. But what can it be? deno varies yes, but the deno std lib that parses yaml is pinned.

mxcl avatar May 10 '24 20:05 mxcl

Running CI on main https://github.com/pkgxdev/libpkgx/actions/runs/9037714306

mxcl avatar May 10 '24 20:05 mxcl

Running CI on main https://github.com/pkgxdev/libpkgx/actions/runs/9037714306

well, the failure is some kind of relief, certainly.

jhheider avatar May 10 '24 20:05 jhheider

i was thinking the problem could have unicode characters and linux charsets; but hexedit scanning of that file doesn't support it, and most of the rest of our stack should complain if that were it.

jhheider avatar May 10 '24 20:05 jhheider

Pull Request Test Coverage Report for Build 10737221966

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 83.052%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hooks/useConfig.ts 1 2 50.0%
<!-- Total: 5 6
Totals Coverage Status
Change from base Build 10737200673: 0.07%
Covered Lines: 2446
Relevant Lines: 2878

💛 - Coveralls

coveralls avatar Sep 06 '24 11:09 coveralls