brewkit icon indicating copy to clipboard operation
brewkit copied to clipboard

need to sanitize `+brewing` from more locations

Open jhheider opened this issue 1 year ago • 1 comments

things currently in the pantry (may be solved already):

.cmake files:

    - run: sed -i
        -e "s:{{ pkgx.prefix }}:\$\{CMAKE_CURRENT_LIST_DIR\}/../../../../..:g"
        -e "s/\+brewing//g"
        abslTargets{,-release}.cmake
      working-directory: '{{prefix}}/lib/cmake/absl'

.pc files:

    # FIXME: this is a hack; we need to fix fixup.ts
    - run: sed -i 's/\+brewing//g' *.pc
      working-directory: '{{prefix}}/lib/pkgconfig'

possible contender:

    # the make file uses sed over the bindir, our +brewing messes that up.
    - TMP_PREFIX=$(mktemp -d)

.la files going in now for graphviz.org to solve:

/opt/gnu.org/sed/v4.9.0/bin/sed: can't read /opt/graphviz.org/v10.0.1+brewing/lib/libxdot.la: No such file or directory

jhheider avatar Mar 06 '24 23:03 jhheider

+brewing is broken at some level and needs revisiting. In general it should be transparent:

  • any bug is either exposing general relocatability issues; or
  • should be transparent since at any point during builds it is just {{prefix}}

The fact it seems to otherwise surface to build scripts suggests some issue.

mxcl avatar Mar 09 '24 12:03 mxcl